Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Delete dialogs] Adapt the delete dialogs to the kids flavor. #22

Merged
merged 2 commits into from Aug 3, 2016

Conversation

vbarthel-fr
Copy link
Member

@vbarthel-fr vbarthel-fr commented Jul 31, 2016

In the kid version of the app, the dialog displayed to confirm the deletion
of a color or of a palette are now text free.

Default version:

device-2016-07-31-164556
device-2016-07-31-164631

Version for kids:

device-2016-07-31-164730
device-2016-07-31-164756

@tbarthel-fr
Copy link
Member

LGTM 🌴
as discussed I would have created a DeletePaletteView in each flavor instead of static method but it would be the same result.

@tbarthel-fr tbarthel-fr removed their assignment Jul 31, 2016
vbarthel-fr and others added 2 commits August 3, 2016 08:10
In the kid version of the app, the dialog displayed to confirm the deletion
of a color or of a palette now contains no texts.
@tbarthel-fr tbarthel-fr merged commit 129246c into kid-matters Aug 3, 2016
@tbarthel-fr tbarthel-fr deleted the vb/delete-dialogs branch August 3, 2016 06:22
@jo-elimu
Copy link
Member

jo-elimu commented Aug 3, 2016

@vbarthel-fr This looks very good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants