[Palette creation] Adapt the palette creation to the kid flavor. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| mToast = Toast.makeText(this, resId, Toast.LENGTH_SHORT); | ||
| mToast.show(); | ||
| } | ||
| protected abstract void createPalette(); |
There was a problem hiding this comment.
would add a small comment for maintainability : called when user validate the palette creation.
|
LGTM 💇 |
vbarthel-fr
force-pushed
the
vb/palette-creation
branch
from
3843a43
to
86a9ff0
Compare
Merged
|
@vbarthel-fr rebase kid-matters. |
In the kid version, the instruction is represented as an image, and a default name is used. In the default version, the instruction is in plain text, and the name of the palette is choose by the user from a dialog.
tbarthel-fr
force-pushed
the
vb/palette-creation
branch
from
86a9ff0
to
9eda833
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the kid version, the instruction is represented as an image, and a default name is used.
In the default version, the instruction is in plain text, and the name of the palette
is choose by the user from a dialog.
Note: the floating action button is now only displayed when at least one color has been added to the palette creator.