-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VoxelSniper turns | into newlines #1
Comments
Sorry, I first read this as a lowercase "L", not a pipe "|" which confused me. The pipe breaks are supposed to allow you to chain multiple commands together with one line, the issue here obviously as you described that someone could easily use it to spam multiple lines. I'm not sure if this feature is used, I don't use it personally, but for the sake of leaving it in, I will go ahead and modify this portion to only allow commands to be sent through if the first character is a forward slash "/". Thank you for reporting this issue. |
d86b839 Just pushed a fix for this, please verify if this has resolved your issue. |
The other problem is that plugins that use pipe as a delmiter break with this. I should have mentioned that initially. |
there are plugins that use a pipe as a delimiter? That's quite odd. Most people should be using colons or commas. >.< |
I think we should use another method for handling pre-process commands that wont interfere with others plugins, basically sandbox it away from the other commands. I assumed it was doing this already, that's what confused me when I first read this. I will look into this. |
I think it should just be taken out altogether. |
Alright, I'll go ahead and remove the feature. As stated before, it's not even officially documented, and it's proven as listed here to be both an exploit and a problem with other plugins. |
4d17a41 This feature has now been removed from the repository with the listed commit. |
Peter did this as a sort of "screw you" to WorldEdit, as the feature doesn't work with WorldEdit commands. |
Hello,
VoxelSniper turns all |'s into newlines, which breaks some plugins and allows for lots of linespam (e.g., a|a|a|a|a). Looking at the source, it seems to split all |'s into newlines. Any reason for this?
The text was updated successfully, but these errors were encountered: