Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visualizations #18

Open
tw4l opened this issue Aug 6, 2019 · 11 comments
Open

Add visualizations #18

tw4l opened this issue Aug 6, 2019 · 11 comments

Comments

@tw4l
Copy link
Owner

tw4l commented Aug 6, 2019

e.g. pie charts using D3.js

@ablwr
Copy link
Collaborator

ablwr commented Oct 2, 2019

I have been playing around with this and came over to file an issue to ask if this kind of addition would be welcome --

Screenshot from 2019-10-02 09-37-47

I have some considerable clean-up to do; the code is super messy and styling has to be considered (colors are just hardcoded from an example instead of auto-generated for each new data point). But assuming clean-up, it seems like this would be a fine PR to make. Are there more specific things you had in mind re: visualizations/reporting, Tim?

@tw4l
Copy link
Owner Author

tw4l commented Oct 4, 2019

Ashley! This is so great! This is just the kind of thing I had in mind. A great addition! I'll follow up the details in PR #22, but thank you so much!

@ablwr
Copy link
Collaborator

ablwr commented Oct 5, 2019

OK! Yeah it still needs a bit of cleanup, I think, for better positioning ... but glad you like it and I'll keep moving forward! I wonder what other kinds of visualizations are useful?

@tw4l
Copy link
Owner Author

tw4l commented Oct 5, 2019

Yay! A bit of spitballing:

  • I think some sort of timeline/clustering visualization of the last modified dates could be interesting (although it's dependent on FITS, so won't be available for every file)
  • Potentially variations on the format chart, so a user could select to visualize formats, format versions, or PUIDs
  • What might really make these interesting/useful is if we can generalize it so that the user can select whether they want the visualizations (and table below) to be about the original files, preservation derivatives, metadata/submission documentation, or all files. This will depend on some backend changes, many of which I've already been playing with in the 'develop' branch. But for the scope of this work, it means the more we can make these generic components the better

I just merged your branch here and made the semantic changes I mentioned in the PR. Feel free to hack away on the visualizations (I'm assuming time/interest here - you've already made such great contributions here, please feel free to step away at any time!) and maybe I'll focus on the backend changes to support types of files other than original.

@tw4l
Copy link
Owner Author

tw4l commented Oct 6, 2019

Another idea that would also take some backend work: it could be interesting to try to visualize the relationships between the original files and their preservation derivatives - comparing formats before and after, for instance

@ablwr
Copy link
Collaborator

ablwr commented Oct 8, 2019

Yes! Yeah I'm still interested, even if my freetime is a bit low for this work so PRs won't be as fervent as I'd like them to be. But I gotta keep my skills up!

@tw4l
Copy link
Owner Author

tw4l commented Oct 9, 2019

I totally get that! Sounds good :)

@tw4l
Copy link
Owner Author

tw4l commented Jan 7, 2020

Hi Ashley! I did a bit more layout work on this and think it's ready to go live as-is if you're keen! Of course you're always welcome to open new PRs too :)

@ablwr
Copy link
Collaborator

ablwr commented Jan 7, 2020

omg thanks!! My free time has stayed low since October although I do think about this and wanting to contribute. Don't let my lack of time block you in any way.

@tw4l
Copy link
Owner Author

tw4l commented Jan 7, 2020

Thank you! I appreciate that you spent some of your rare free time on this, and the door will always be open if you wanna do any more! I'm going to leave this issue open as a reminder to swing back and generalize the visualization beyond formats at some point...

@ablwr
Copy link
Collaborator

ablwr commented Jan 7, 2020

Of course! It really wasn't much work at all -- I like to think the biggest part was motivating you to do even MORE work after me to tidy up my sloppy quickly-drafted mess. 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants