Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use escallmatch module to describe target enhancement patterns #12

Merged
merged 42 commits into from Aug 12, 2014

Conversation

twada
Copy link
Member

@twada twada commented Aug 12, 2014

Use escallmatch module to describe target enhancement patterns.

TODO

  • Rough implementation
  • Maint tests
  • Delete targetMethods from config
  • Refine internals
  • README
  • CHANGELOG

twada added 30 commits August 7, 2014 00:04
test empower function preserves return value if target assertion function itself returns something
…itself

the case when assertion function call is not listed in patterns (even if methods do)
…nRethrow`

BREAKING CHANGE: `modifyMessageOnFail` option is renamed to `modifyMessageOnRethrow`

There is nothing to change unless you are using `modifyMessageOnFail` option.

If you are using `modifyMessageOnFail` option, change your code from the following:

`empower(originalAssert, formatter, {modifyMessageOnFail: true})`

To:

`empower(originalAssert, formatter, {modifyMessageOnRethrow: true})`
…hrow`

BREAKING CHANGE: `saveContextOnFail` option is renamed to `saveContextOnRethrow`

There is nothing to change unless you are using `saveContextOnFail` option.

If you are using `saveContextOnFail` option, change your code from the following:

`empower(originalAssert, formatter, {saveContextOnFail: true})`

To:

`empower(originalAssert, formatter, {saveContextOnRethrow: true})`
@coveralls
Copy link

Coverage Status

Coverage increased (+0.76%) when pulling 54bee86 on escallmatch into 10edf49 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.76%) when pulling 6a6a3cb on escallmatch into 10edf49 on master.

@twada twada changed the title [WIP] use escallmatch module to describe target enhancement patterns use escallmatch module to describe target enhancement patterns Aug 12, 2014
twada added a commit that referenced this pull request Aug 12, 2014
use escallmatch module to describe target enhancement patterns
@twada twada merged commit 3fb6f07 into master Aug 12, 2014
@twada twada deleted the escallmatch branch August 12, 2014 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants