Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use escallmatch module to describe instrumentation target patterns. #10

Merged
merged 4 commits into from
Aug 2, 2014

Conversation

twada
Copy link
Member

@twada twada commented Jul 31, 2014

Extract and require escallmatch module to describe instrumentation target patterns.

With escallmatch, instrumentation patterns could be described as below.

{
   ....
        patterns: [
            'assert(value, [message])',
            'assert.ok(value, [message])',
            'assert.equal(actual, expected, [message])',
            'assert.notEqual(actual, expected, [message])',
            'assert.strictEqual(actual, expected, [message])',
            'assert.notStrictEqual(actual, expected, [message])',
            'assert.deepEqual(actual, expected, [message])',
            'assert.notDeepEqual(actual, expected, [message])'
        ]
}

TODO

  • Extract escallmatch module
  • Rough implementation
  • Maint tests
  • Delete targetMethods from config
  • Delete powerAssertVariableName from config
  • MemberExpression of MemberExpression like browser.assert.hasClass(selection, className, [message])
  • Refactor

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.97%) when pulling e75e5d3 on escallmatch into b57ac16 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.45%) when pulling ea0a3ce on escallmatch into b57ac16 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.45%) when pulling 1781f77 on escallmatch into b57ac16 on master.

twada added a commit that referenced this pull request Aug 2, 2014
[WIP] Use escallmatch module to describe instrumentation target patterns.
@twada twada merged commit c21d5b5 into master Aug 2, 2014
@twada twada changed the title [WIP] Use escallmatch module to describe instrumentation target patterns. Use escallmatch module to describe instrumentation target patterns. Aug 2, 2014
@twada twada deleted the escallmatch branch August 2, 2014 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants