Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Third-party modules #3

Merged
merged 11 commits into from Dec 22, 2013
Merged

Third-party modules #3

merged 11 commits into from Dec 22, 2013

Conversation

twada
Copy link
Member

@twada twada commented Dec 18, 2013

Trying to use well-tested third-party modules instead of private clones.

Searching for modules that works with

  • Node.js
  • Browser
  • (Hopefully) AMD

Then, test them on browser/AMD too!

TODO

  • Migrate traverse function to estraverse module
  • Test and CI under browser
  • Test and CI under AMD
  • Refactoring (reduce complexity!)

@ghost ghost assigned twada Dec 18, 2013
@coveralls
Copy link

Coverage Status

Coverage increased (+1.32%) when pulling 27bcd15 on deps into 5d83486 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 67011ea on deps into 5d83486 on master.

This reverts commit 8567d87.
This does not mean deepcopy module is slow because deepcopy module provides a general purpose deep copy function.
I've noticed that I want a simple and fast deep copy function just for Mozilla JavaScript AST only.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.64%) when pulling b301c90 on deps into 5d83486 on master.

twada added a commit that referenced this pull request Dec 22, 2013
[WIP] Third-party modules
@twada twada merged commit 261c194 into master Dec 22, 2013
@twada twada deleted the deps branch December 23, 2013 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants