Geocoding fails when searching for both name and house number

[scaidermern]

As reported via help.openstreetmap.org the search yields no result when searching for both the name and the house number. Example:

• Searching for the name succeeds
• Searching for the house number succeeds
• Searching for both the name and the house number fails

[hohl]

May be related to my bug: When searching for a full address (like "Sample Street 123") it always finds "Sample Street" but not the exact house. (But the exact house number is noted correctly in OSM) Seems to be related with how long the street is too.

[arvindkartik]

I came across a similar issue. Searching for "Upper Camden Street, Saint Kevin's, Dublin 2" would work, but adding a house number to the query would not give any results.

Search query up to street level succeeds

Search query with house number fails

[joy-yyd]

Hello,
Regarding the problem mentioned in #1821, we've modified the tag to addr:place=place_name and load the data in local Nominatim, it seems still not able to find the place with House number. Is it possible to add more tags to the parent node?
Thanks a lot for your help!

[joy-yyd]

We were testing our data of Austria (downloaded from https://www.geofabrik.de/) with the new release 3.5.1, however, we found many issues with the house number, e.g.

1. We found: https://nominatim.openstreetmap.org/search.php?q=Universit%C3%A4tsklinikum+St.+P%C3%B6lten%2C+Sankt+P%C3%B6lten%2C+3100&polygon_geojson=1&viewbox=
   Not found with house number: https://nominatim.openstreetmap.org/search.php?q=Universit%C3%A4tsklinikum+St.+P%C3%B6lten%2C+1%2C+Sankt+P%C3%B6lten%2C+3100&polygon_geojson=1&viewbox=
2. Found https://nominatim.openstreetmap.org/search.php?q=Universit%C3%A4tsklinikum+Tulln%2CAlter+Ziegelweg%2CTulln%2C3430&polygon_geojson=1&viewbox=
   Not found: https://nominatim.openstreetmap.org/search.php?q=Universit%C3%A4tsklinikum+Tulln%2C10%2CAlter+Ziegelweg%2CTulln%2C3430&polygon_geojson=1&viewbox=
3. Found: https://nominatim.openstreetmap.org/search.php?q=Krankenhaus+Theresienhof%2C+Frohnleiten%2C+8130&polygon_geojson=1&viewbox=
   Not found: https://nominatim.openstreetmap.org/search.php?q=Krankenhaus+Theresienhof+%2C3-5%2CFrohnleiten%2C+8130&polygon_geojson=1&viewbox=
   We have modified/added the place tags to the data and imported to the database, but not able to fix the issues.
   Is there a plan to fix this bug in the new release? Thanks a lot for your advice!

[lonvia]

There are no immediate plans for a fix. It's not exactly trivial.

[joy-yyd]

Hello Sarah, I modified the address_rank as $aTerms[] = 'address_rank between 16 and 30'; in https://github.com/osm-search/Nominatim/blob/master/lib/SearchDescription.php#L660. Wit this change, it seems to have found the places by name with house number for the examples above in Austria. Then, I tested some addresses for the house number with the street and no house number search, the results are the same as the original code. I am wondering if there is a downside of this fix? Or I can ask for a pull request for the change. Many thanks!

[lonvia]

This might work. I don't think there is too much overlap with streets and POI names here. Feel free to do a PR.

[lonvia]

Fixed by #1874.

[joy-yyd]

Hello Sarah,
As we are testing the Release 3.5.1, we found that the code seems not changed, though the pull request has been merged, as the following:

Nominatim/lib/SearchDescription.php

Line 660 in 168c2e2

$aTerms[] = 'address_rank between 16 and 27';

Could you help us to merge it again if the code is reverted?
Thanks a lot!
Joy

[lonvia]

#1874 is not in the 3.5.1 release as it was merged later.

[joy-yyd]

ok, thank you Sarah!

[juanpelegrina]

#1874 is not in the 3.5.1 release as it was merged later.

any idea on when the next release is planned?

[lonvia]

Tomorrow. However, this particular feature will only be included when we do the 3.6 release which is still a couple of months away.