during reverse geocode lookup we also check the (optional) Tiger data

[mtmail]

When we don't find a result with rank 30 (building name, house number etc) but find a road, then inside the US we also check the nearest Tiger house numbers who have the street as parent.

The osm_type is 'T' and the osm_id is the place_id. Not entirely sure if that makes sense but Geocode.php sets the same.

In PlaceLookup.php right after if ($this->bIsTiger) it would be possible to use a UNION to combine both SQL queries. But since it's a direct lookup by place_id and we already know the place is a Tiger place a single query is enough.

I've setup a server at http://46.101.149.108:9876/nominatim were you can test the results. For example http://46.101.149.108:9876/nominatim/reverse.php?format=xml&lat=40.6859534063625&lon=-112.055149368461 which will return 6882, Kings Estate Drive, West Valley City, Salt Lake County, 84128, United States of America.

The server has only data loaded for the Salt Lake City, Utah area. See the bounding box on http://bboxfinder.com/#40.310949,-112.376404,41.391234,-111.549683

This feature got sponsored/paid for by Guru Labs. Thanks a lot!

[lonvia]

rank_search == 27 might be relevant, too (named service roads, tracks and footways)

[mtmail]

Thanks for reviewing.

• added rank_search==27 for non-highways
• on smaller zoom levels (<17) we now skip looking at Tiger data
• improved test. You're right, it even passed against an unchanged Nominatim installation

Running the test case:
NOMINATIM_SERVER=http://46.101.149.108:9876/nominatim lettuce features/api/reverse.feature --tag=Tiger => pass
NOMINATIM_SERVER=http://nominatim.openstreetmap.org lettuce features/api/reverse.feature --tag=Tiger => fail (expected)

[lonvia]

Merged, thanks a lot. The new feature will be deployed on nominatim.osm.org in the next couple of days.