direct-mapping with type-mapper return-types crashes

[marco2357]

If OwnString is handled in a type mapper (instead of being NativeMapped), calling this strstr() method will crash due to the return type (arguments work, return types not):

class Test {
   static {
      Native.register(NativeLibrary.getInstance(C_LIBRARY_NAME, mapWithOwnTypeMapper));
   }

   private static native OwnString strstr(OwnString haystack, OwnString needle);
}

Here the fix (the result is created but never used/assigned):

diff --git a/native/dispatch.c b/native/dispatch.c
index 71fd083..fc17dd7 100644
--- a/native/dispatch.c
+++ b/native/dispatch.c
@@ -1149,6 +1149,9 @@
       if (type->type != FFI_TYPE_POINTER) {
         extract_value(env, obj, result, type->size, JNI_TRUE);
       }
+      else {
+        *(jobject*)result = obj;
+      }
     }
   }
 }

[twall]

Please provide an associated test case in a PR.

Thanks

On Apr 7, 2014, at 9:17 AM, marco2357 notifications@github.com wrote:

If OwnString is handled in a type mapper (instead of being NativeMapped), calling this strstr() method will crash due to the return type (arguments work, return types not):

class Test {
static {
Native.register(NativeLibrary.getInstance(C_LIBRARY_NAME, mapWithOwnTypeMapper));
}

private static native OwnString strstr(OwnString haystack, OwnString needle);
}

Here the fix (the result is created but never used/assigned):

diff --git a/native/dispatch.c b/native/dispatch.c
index 71fd083..fc17dd7 100644
--- a/native/dispatch.c
+++ b/native/dispatch.c
@@ -1149,6 +1149,9 @@
if (type->type != FFI_TYPE_POINTER) {
extract_value(env, obj, result, type->size, JNI_TRUE);
}

•  else {
  

•    _(jobject_)result = obj;
  

•  }
  

  }
  }
  }

—
Reply to this email directly or view it on GitHub.

[dblock]

Closed via #319.