Provide support for the Windows RAS32 API

[kc7bfi]

I've provided new code to add support for Windows RAS32 API.

[dblock]

This looks great. Can you please add a line into CHANGES.md? Thx.

[dblock]

There're also a lot of tests missing, for things like RasGetCredentials. It's not always obvious how to write a test for something like this, but a negative test is useful: call it with some invalid parameter and expect that it returns an expected error, for example.

[kc7bfi]

OK, I've added the line in CHANGES.md. I wasn't sure how to generate
tests without actually creating or dialing RAS phone book entries.

David R Robison
Open Roads Consulting, Inc.
103 Watson Road, Chesapeake, VA 23320
phone: (757) 546-3401
e-mail: drrobison@openroadsconsulting.com
web: http://openroadsconsulting.com
blog: http://therobe.blogspot.com
book:
http://www.xulonpress.com/bookstore/bookdetail.php?PB_ISBN=9781597816526

On Monday, September 23, 2013 4:01:20 PM, Daniel Doubrovkine (dB.)
wrote:

There're also a lot of tests missing, for things like
|RasGetCredentials|. It's not always obvious how to write a test for
something like this, but a negative test is useful: call it with some
invalid parameter and expect that it returns an expected error, for
example.

—
Reply to this email directly or view it on GitHub
#267 (comment).

This email communication (including any attachments) may contain confidential and/or privileged material intended solely for the individual or entity to which it is addressed.
If you are not the intended recipient, please delete this email immediately.

[kc7bfi]

OK, I've added more tests, I think the pull request should be good now.
David

David R Robison
Open Roads Consulting, Inc.
103 Watson Road, Chesapeake, VA 23320
phone: (757) 546-3401
e-mail: drrobison@openroadsconsulting.com
web: http://openroadsconsulting.com
blog: http://therobe.blogspot.com
book:
http://www.xulonpress.com/bookstore/bookdetail.php?PB_ISBN=9781597816526

On Monday, September 23, 2013 4:05:37 PM, David R Robison wrote:

OK, I've added the line in CHANGES.md. I wasn't sure how to generate
tests without actually creating or dialing RAS phone book entries.

David R Robison
Open Roads Consulting, Inc.
103 Watson Road, Chesapeake, VA 23320
phone: (757) 546-3401
e-mail: drrobison@openroadsconsulting.com
web: http://openroadsconsulting.com
blog: http://therobe.blogspot.com
book:
http://www.xulonpress.com/bookstore/bookdetail.php?PB_ISBN=9781597816526

On Monday, September 23, 2013 4:01:20 PM, Daniel Doubrovkine (dB.) wrote:

There're also a lot of tests missing, for things like
|RasGetCredentials|. It's not always obvious how to write a test for
something like this, but a negative test is useful: call it with some
invalid parameter and expect that it returns an expected error, for
example.

—
Reply to this email directly or view it on GitHub
#267 (comment).

This email communication (including any attachments) may contain confidential and/or privileged material intended solely for the individual or entity to which it is addressed.
If you are not the intended recipient, please delete this email immediately.

[dblock]

Merged, thanks for contributing.