Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'samples_dict' in a draw function, 'samples' in simulation function #62

Closed
twallema opened this issue Aug 7, 2023 · 2 comments
Closed

'samples_dict' in a draw function, 'samples' in simulation function #62

twallema opened this issue Aug 7, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@twallema
Copy link
Owner

twallema commented Aug 7, 2023

A draw function is defined as follows,

def draw_function(param_dict, samples_dict):
    return param_dict

The argument samples_dict is passed from the sim function, where it is named samples. I suggest renaming samples_dict to samples and param_dict to parameters for uniformity.
@twallema twallema added the enhancement New feature or request label Aug 7, 2023
@twallema
Copy link
Owner Author

Partly addressed in PR #73 .
To be further generalized.

@twallema
Copy link
Owner Author

Fully generalized in PR #75
Closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@twallema