Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

W012 isn't necessarily true in Bootstrap 4 #408

Closed
valin4tor opened this issue Aug 25, 2017 · 3 comments
Closed

W012 isn't necessarily true in Bootstrap 4 #408

valin4tor opened this issue Aug 25, 2017 · 3 comments

Comments

@valin4tor
Copy link

valin4tor commented Aug 25, 2017

A navbar's first child shouldn't be a container if the navbar is inside a container itself. See https://getbootstrap.com/docs/4.0/examples/navbars/ - the light floating navbars do not have a container inside them as this would result in extra unwanted padding.

@cvrebert
Copy link
Collaborator

Bootlint has not yet been updated for Bootstrap 4. Only Bootstrap 3 is currently supported.

@cvrebert cvrebert changed the title W012 isn't necessarily true W012 isn't necessarily true in Bootstrap 4 Aug 25, 2017
@Herst
Copy link
Collaborator

Herst commented Sep 5, 2017

See also #304.

@XhmikosR XhmikosR closed this as completed Sep 7, 2017
@pjmcdermott
Copy link

The container documentation for Bootstrap 3 says:

Note that, due to padding and more, neither container is nestable.

There is a good explanation of why in The Subtle Magic Behind Why the Bootstrap 3 Grid Works.

So I don't think W012 is true even in Bootstrap 3. This issue should be re-opened.

I suspect the issues is that navbar-* elements should be in a container, but this does not mean that a navbar's 1st child element must be a container.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants