Skip to content
This repository has been archived by the owner on Mar 30, 2023. It is now read-only.

update for v5 #35

Closed
HansUXdev opened this issue Dec 31, 2020 · 6 comments
Closed

update for v5 #35

HansUXdev opened this issue Dec 31, 2020 · 6 comments

Comments

@HansUXdev
Copy link

HansUXdev commented Dec 31, 2020

I'm working on a PR right now to deal address the other issues and PR's that haven't been approved and wanted to clearify a few things.

@mdo what are the overall goals of this template?
Is it meant to only support only v4 / is there any opposition to updating to the v5 (beta1 currently)?
Would there be any opposition to a massive PR, or does the bootstrap team prefer single issue PR's?

Example of a massive PR:

  • uses v5
  • add livereload live reload not works. #21
  • and improve scripts with npm improve and simplify scripts #22 to have npm start, babel, lint, post-css, etc
  • add support for gitpod and or codespaces (try this repo out in the browser)
  • add optional vscode extension recommendation
  • Update Documentation to reflect the above

Some people have compared this to CRA, however, I really like the fact that the template doesn't hide the tooling like CRA.
Personally, I see this as a great resource for beginners to learn bootstrap and would like to improve it.

@mdo
Copy link
Member

mdo commented Dec 31, 2020

Any help here would be very much appreciated! Definitely want to include v5 in this with a new tagged release. A single massive PR would be a little difficult to manage though. Any chance we could break things down into smaller PRs?

@HansUXdev
Copy link
Author

Any help here would be very much appreciated! Definitely want to include v5 in this with a new tagged release. A single massive PR would be a little difficult to manage though. Any chance we could break things down into smaller PRs?

I'm not opposed to that.
I started it by adding most, if not everything from the existing PR's because those are small changes involving packages, or adding config files for webpack and linting. In terms of breaking it down to smaller PR's, would this be the best starting point? So I'm fine reverting back to the point because it should bring the repo to current.

This is the fork I'm working on:
https://github.com/HansUXdev/bootstrap-npm-starter/tree/v5-beta

I've made detail commits and updated the readme accordingly.
In later commits, I introduced major changes such as moving the scss folder into assets and reworking the npm scripts.

My goal with the later commits was to have two main task, npm start for development with live reload and unminified css & js and a separate production task that minifies and bundles it all.

I have webpack working to compile javascript and provide a live reload via webpack cli, but it doesn't currently reference the webpack file. I also still need to test the JavaScript components in dev and production mode.

@bardware
Copy link

bardware commented Apr 3, 2021

I came here throught the bootstrap 5 site and was surprised this project still uses node-sass according to the package.json

@alundiak alundiak mentioned this issue May 14, 2021
3 tasks
@kanlukasz
Copy link

When will the official launch of the starter for v5 take place?

@RobJacobson
Copy link

I'm new to Bootstrap. I naturally want to play with the "latest and greatest" version, so this repo doesn't currently meet my expectations/needs.

There seems to have been a pending pull request for several months. Any chance this could be integrated/finished?

@mandrasch
Copy link

mandrasch commented Jul 19, 2021

I built a simple starter repo with eleventy framework, maybe useful while waiting :-)
https://github.com/mandrasch/11ty-plain-bootstrap5

@mdo mdo closed this as completed Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants