Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add a btn-dark button option #10269

Closed
SharpNoiZy opened this issue Aug 29, 2013 · 6 comments
Closed

Please add a btn-dark button option #10269

SharpNoiZy opened this issue Aug 29, 2013 · 6 comments

Comments

@SharpNoiZy
Copy link

Hi,

I think there is no real issue for that.
There were comments in some other issues that wish also back the dark button but no seperate issue/feature request for that.
So I would love to have the dark button back from RC1, not as default, because the effect would be to heavy on other devs, but as additional option btn-dark, would be great.

Kind regards

@msheakoski
Copy link

.btn-dark is not a semantic class name because it describes how it looks rather than what it does. See http://www.w3.org/QA/Tips/goodclassnames. Your best bet is to customize the default button colors or create your own class called something like .btn-default-alt which contains the darker style.

@markwienands
Copy link

It's something you can add yourself to your own stylesheet ie custom.css

.btn-secondary          { color: #ffffff; background-color: #777; border-color: #555; }
.btn-secondary:hover, .btn-secondary:focus, .btn-secondary:active, .btn-secondary.active, .open .dropdown-toggle.btn-secondary
                        { color: #ffffff; background-color: #888; border-color: #444; }

@ggam
Copy link
Contributor

ggam commented Aug 29, 2013

Or better yet, calling button-variant https://github.com/twbs/bootstrap/blob/master/less/mixins.less#L428

@juthilo
Copy link
Collaborator

juthilo commented Aug 29, 2013

Closing as dupe of oh so many, e.g. #9878.

@juthilo juthilo closed this as completed Aug 29, 2013
@gamelodge
Copy link

If its a "dupe of oh so many", perhaps we should stop closing and discuss further.

Most solutions say to create your own variant with the .button-variant mixin, however if I want a black button then the mixing hover does not work because it uses background-color: darken(@background, 10%);

Perhaps semantics is getting in the way of common sense.

@cvrebert
Copy link
Collaborator

cvrebert commented Mar 3, 2015

@gamelodge Feel free to open a new issue, since this one is 1.5 years old and closed, with your specific darken-related rationale. Although I wouldn't get your hopes up.

@twbs twbs locked and limited conversation to collaborators Mar 3, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants