Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 3rd party asset libraries #11671

Merged
merged 3 commits into from Dec 5, 2013
Merged

Update 3rd party asset libraries #11671

merged 3 commits into from Dec 5, 2013

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Dec 2, 2013

Unfortunately, I can't test the changes properly on Windows being that jekyll fails and I end up with zero byte html files...

I can split the updates to separate PRs if needed.

@sitefinitydcx
Copy link

+1 on the updates, have you checked the .less end result?

Less v1.40 depricated this:

(~".myclass_@{index}") { ... selector interpolation is deprecated, do this instead .myclass_@{index} 

Have you checked that still works with less v1.5.0 ? Also they've released 1.5.1 due to an incompatibility bug with requireJS

@cvrebert
Copy link
Collaborator

cvrebert commented Dec 2, 2013

For consistency, we can't update less.js: RECESS is still on less.js v1.3.x.

@XhmikosR
Copy link
Member Author

XhmikosR commented Dec 2, 2013

@jbokkers: I cannot test properly because on Windows I end up with zero byte html files, without any visible error from jekyll.

@cvrebert: OK I will revert the less update. Any other changes you'd like me to make?

@mdo
Copy link
Member

mdo commented Dec 2, 2013

Are these literally just new versions, or is there more going on here? The diffs make it look like this was more of a manual job than just an upgrade. Just want to make sure.

@XhmikosR
Copy link
Member Author

XhmikosR commented Dec 2, 2013

@mdo: I didn't modify the files at all; I just checked the newer versions in. Apparently the filesaver.js version in filesaver.js was minified before, now it isn't hence the so many changes. They also changed from spaces to tabs it seems.

@XhmikosR
Copy link
Member Author

XhmikosR commented Dec 2, 2013

BTW @mdo what do you think about https://github.com/XhmikosR/bootstrap/compare/min-assets? Should I make a PR about that?

I still need to fix or at least work around the issue with grunt-jekyll on WIndows in order to be able to test properly.

@zlatanvasovic
Copy link
Contributor

If I'm right, filesaver.js and jszip.js are now development, instead of stable versions?

@XhmikosR
Copy link
Member Author

XhmikosR commented Dec 3, 2013

Nope it's the same source from the github repository.

@mdo
Copy link
Member

mdo commented Dec 5, 2013

@XhmikosR I'd be down for that consolidation. Open a PR when you can (it'll probably ship with v3.1 given timing).

mdo added a commit that referenced this pull request Dec 5, 2013
Update 3rd party asset libraries
@mdo mdo merged commit 42bee1d into twbs:master Dec 5, 2013
@mdo mdo mentioned this pull request Dec 5, 2013
@XhmikosR XhmikosR deleted the updates branch December 5, 2013 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants