New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 3rd party asset libraries #11671
Conversation
+1 on the updates, have you checked the .less end result? Less v1.40 depricated this:
Have you checked that still works with less v1.5.0 ? Also they've released 1.5.1 due to an incompatibility bug with requireJS |
For consistency, we can't update less.js: RECESS is still on less.js v1.3.x. |
Are these literally just new versions, or is there more going on here? The diffs make it look like this was more of a manual job than just an upgrade. Just want to make sure. |
@mdo: I didn't modify the files at all; I just checked the newer versions in. Apparently the filesaver.js version in filesaver.js was minified before, now it isn't hence the so many changes. They also changed from spaces to tabs it seems. |
BTW @mdo what do you think about https://github.com/XhmikosR/bootstrap/compare/min-assets? Should I make a PR about that? I still need to fix or at least work around the issue with grunt-jekyll on WIndows in order to be able to test properly. |
If I'm right, filesaver.js and jszip.js are now development, instead of stable versions? |
Nope it's the same source from the github repository. |
@XhmikosR I'd be down for that consolidation. Open a PR when you can (it'll probably ship with v3.1 given timing). |
Unfortunately, I can't test the changes properly on Windows being that jekyll fails and I end up with zero byte html files...
I can split the updates to separate PRs if needed.