cleanup Gruntfile by extracting executable code #12150
Conversation
|
@cvrebert, I would like to follow a similar pattern for the grunt task in #12112. However, I am not sure if the perf grunt task should be inside docs/perf.js as it is not related to docs. Is there a reason why you moved the docs grunt task logic into docs. I have seen other projects have a build folder, under which all the special build tasks exist. What should be the way I should change #12112 so that it is consistent with the pattern in this pull request ? |
Because, ignoring your PR, all the custom grunt tasks are docs-related, and we don't have/use a
Move perf.js under /test-infra/. |
|
It's possible we'll revisit the location of the files at some point; the main thing is that the code is out of the Gruntfile. |
cleanup Gruntfile by extracting executable code
|
|
||
| fs.writeFileSync('docs/_data/glyphicons.yml', glyphiconsData) | ||
| }); | ||
| grunt.registerTask('build-glyphicons-data', generateGlyphiconsData); |
There was a problem hiding this comment.
Is there a reason why you register the generateGlyphiconsData as a function and not load the file as a grunt task instead. I also see that you use readFileSync instead of grunt.file.read, if this was a grunt task. Should I do the same for #12112 ?
There was a problem hiding this comment.
No, no particular reason.
This cleans up the Gruntfile by moving the nontrivial executable code out of it and into separate modules.