Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly reset borders on table cells in panels #12633

Merged
merged 2 commits into from Feb 8, 2014
Merged

Conversation

mdo
Copy link
Member

@mdo mdo commented Feb 7, 2014

Fixes #12447.

This makes the Less code more verbose, but it's more specific and solves the problem we have today as of v3.1. This fix also trumps #12489 and fixes #12596 (dupe of #12447).

See the change in action: http://jsbin.com/lowo/2/.

@mdo mdo mentioned this pull request Feb 7, 2014
@zlatanvasovic
Copy link
Contributor

Wow. There is a lot fixes for tables within panels, but this one should fix them finally. 🉑

@mdo
Copy link
Member Author

mdo commented Feb 7, 2014

I plan on dropping as much of this as possible come v4. This is exactly why I removed rounded corners and other fancy things in our tables with v3 😑.

@mdo mdo added the css label Feb 7, 2014
@mdo mdo added this to the v3.1.1 milestone Feb 7, 2014
@zlatanvasovic
Copy link
Contributor

Yeah, they're such a mess. :D

2014-02-07 11:55 GMT+01:00 Mark Otto notifications@github.com:

I plan on dropping as much of this as possible come v4. This is exactly
why I removed rounded corners and other fancy things in our tables with v3 [image:
😑].


Reply to this email directly or view it on GitHubhttps://github.com//pull/12633#issuecomment-34426039
.

Zlatan Vasović - ZDroid

Conflicts:
	dist/css/bootstrap.css.map
	dist/css/bootstrap.min.css
	docs/dist/css/bootstrap.css.map
	docs/dist/css/bootstrap.min.css
mdo added a commit that referenced this pull request Feb 8, 2014
Properly reset borders on table cells in panels
@mdo mdo merged commit c3f8456 into master Feb 8, 2014
@mdo mdo deleted the panels_and_tables branch February 8, 2014 02:50
@mdo mdo mentioned this pull request Feb 8, 2014
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants