Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update teams #12665

Merged
merged 2 commits into from
Feb 11, 2014
Merged

Update teams #12665

merged 2 commits into from
Feb 11, 2014

Conversation

mdo
Copy link
Member

@mdo mdo commented Feb 9, 2014

Fixes #12663.

This updates the docs teams to add @XhmikosR and remove two folks from the Sass port since they don't have access to it and haven't contributed since making it official. If I'm way off base on that last part, please call me out @twbs/sass.

Nothing but <3, and yay new people! Also, yay for _data in Jekyll!

@mdo mdo added the docs label Feb 9, 2014
@mdo mdo added this to the v3.1.1 milestone Feb 9, 2014
@@ -0,0 +1,7 @@
- name: Thomas McDonald
user: mdo
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdo Um...

@mdo
Copy link
Member Author

mdo commented Feb 9, 2014

😁

@XhmikosR
Copy link
Member

XhmikosR commented Feb 9, 2014

Awesome as usual!

I'm not sure it's worth mentioning me there but it's your call :)

BTW, perhaps we could auto-generate this data via GitHub's API with javascript? Should save the trouble of maintaining new files as long as the GitHub teams are set up right.

@mdo
Copy link
Member Author

mdo commented Feb 9, 2014

Meh, the _data lists work out quite nicely. I'm all about less JS, and this doesn't change that often. It should also be much less of a pain in the ass to change.

@XhmikosR Let me know if you wanted your full name out there. I opted for what you use on your profile and kept it anonymous <3.

@XhmikosR
Copy link
Member

XhmikosR commented Feb 9, 2014

It's all fine from my side 👍

@zlatanvasovic
Copy link
Contributor

@XhmikosR I'm experimenting with octonode as GitHub API client, it works nice so far. I just need to finish new Grunt task. Though, this request must be merged before I send new one.

@zlatanvasovic
Copy link
Contributor

General problem with GitHub API is that we can't easily filter people by teams and get real names of members (without complications). _data variant looks like simpler so far.

@XhmikosR
Copy link
Member

XhmikosR commented Feb 9, 2014

@zdroid: since @mdo isn't in favor of this approach, let's leave it for the time being. Thanks for looking into it though!

@zlatanvasovic
Copy link
Contributor

OK, just pointing some things for future. :)

2014-02-09 18:11 GMT+01:00 XhmikosR notifications@github.com:

@zdroid https://github.com/ZDroid: since @mdo https://github.com/mdoisn't in favor of this approach, let's leave it for the time being. Thanks
for looking into it though!


Reply to this email directly or view it on GitHubhttps://github.com//pull/12665#issuecomment-34579267
.

Zlatan Vasović - ZDroid

@mdo
Copy link
Member Author

mdo commented Feb 11, 2014

@thomas-mcdonald @glebm, you two cool with this? Give me your honest opinion—call me out if I'm off base <3.

@glebm
Copy link
Member

glebm commented Feb 11, 2014

Cool with this

@mdo
Copy link
Member Author

mdo commented Feb 11, 2014

Cool, thanks @glebm. I want to be as considerate as possible about the contributions to the official team. Whenever the team intends to grow, just let me know <3<3<3.

mdo added a commit that referenced this pull request Feb 11, 2014
@mdo mdo merged commit 67c4deb into master Feb 11, 2014
@mdo mdo deleted the docs_teams branch February 11, 2014 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add @XhmikosR to Core Team roster in the About page of the docs
5 participants