Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node dependencies. #14847

Merged
merged 2 commits into from
Oct 23, 2014
Merged

Update node dependencies. #14847

merged 2 commits into from
Oct 23, 2014

Conversation

XhmikosR
Copy link
Member

I can't update shrinkwrap at the moment. I keep getting

Running "_update-shrinkwrap" task
Warning: Problems were encountered
Please correct and try again.
invalid: readable-stream@1.0.33-1 C:\Users\xmr\Desktop\bootstrap\node_modules\grunt-contrib-qunit\node_modules\grunt-lib-phantomjs\node_modules\phantomjs\node_modules\request\node_modules\bl\node_modules\readable-stream Use --force to continue.

Aborted due to warnings.

I cleaned node_modules and everything but I still get the error.

@cvrebert
Copy link
Collaborator

Pushed a commit that updates the shrinkwrap.

@cvrebert cvrebert added the meta label Oct 22, 2014
@cvrebert cvrebert added this to the v3.3.0 milestone Oct 22, 2014
@XhmikosR
Copy link
Member Author

@cvrebert: thanks! Can you run it one last time?

Then we only need to rebase and merge.

I still haven't figured out why this fails on my system though...

@cvrebert
Copy link
Collaborator

Done!

cvrebert added a commit that referenced this pull request Oct 23, 2014
@cvrebert
Merge pull request #14847 from twbs/node-deps
3bea2a4 
Update node dependencies.
@cvrebert cvrebert merged commit 3bea2a4 into master Oct 23, 2014
@cvrebert cvrebert deleted the node-deps branch October 23, 2014 20:53
@XhmikosR
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
meta
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@XhmikosR @cvrebert