Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizer: include the minified files only on GitHub pages. #14904

Merged
merged 1 commit into from Oct 29, 2014

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR added this to the v3.3.0 milestone Oct 29, 2014
@hnrch02
Copy link
Collaborator

hnrch02 commented Oct 29, 2014

👍

@cvrebert
Copy link
Collaborator

Maybe add a comment here and in the uglify:customize grunt task that the 2 lists of JS files need to be kept in sync?

@XhmikosR
Copy link
Member Author

@cvrebert: done. I thought the existent comment covered this but it was only for docsJs.

<script src="../assets/js/customize.min.js"></script>
{% else %}
<script src="../assets/js/vendor/less.min.js"></script>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add similar comment here for good measure?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's needed here.

mdo added a commit that referenced this pull request Oct 29, 2014
Customizer: include the minified files only on GitHub pages.
@mdo mdo merged commit c0c1588 into master Oct 29, 2014
@mdo mdo deleted the customize-min-files branch October 29, 2014 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants