Use autoprefixer for Customizer builds #14980
Conversation
|
I think this also solves #14750. The actual Less compilation is async and it was treated as sync before. |
hnrch02
force-pushed
the
customizer-autoprefixer
branch
2 times, most recently
from
b2e5586
to
d370168
Compare
|
@hnrch02: isn't there a minified autoprefixer browser build? |
|
I don't think so. But the deps get uglified anyway when building for GHP so does it matter? |
|
BTW, this reminds me, it's in my TODO list to add a grunt task to generate those browser JS files from the node_modules we use so that we are in sync. I haven't got the time to get to it yet. |
|
In any case it just slows grunt down when the already compressed files get compressed again with no benefit whatsoever. |
|
Again, not my decision. |
|
As for this PR, it breaks download with Firefox again. |
|
Other than, the generated CSS looks good :) |
|
The |
|
You mean if you add it in this branch or it didn't work for you before too? |
|
The download on the current getbootstrap.com doesn't work either in Firefox. |
|
I'm pretty sure it work(ed), because I use the customizer myself and I updated to 3.3.0 successfully the other day. Which Firefox version do you use? |
|
33.0.2 |
|
33.1 x64 and works fine here. Also worked with 33.0.2 x64. |
|
It tried it a couple of times and it seems kinda random. Sometimes it works other times it doesn't. Anyhow, I'll add the timeout back. |
hnrch02
force-pushed
the
customizer-autoprefixer
branch
from
d370168
to
6f146d0
Compare
| try { | ||
| compileLESS(bsLessSource, 'bootstrap', result) | ||
| var prefixer = autoprefixer({ | ||
| browsers: [ |
There was a problem hiding this comment.
Perhaps we could move this data to a separate file to avoid the duplication between here and the Gruntfile?
|
Probably time to file a Firefox bug, IMO, although we'd need to get a more reduced testcase, chopping out the irrelevant parts of FileSaver and Blob.js. |
|
I confirm it works fine now with FF. |
hnrch02
force-pushed
the
customizer-autoprefixer
branch
from
6f146d0
to
1582039
Compare
|
@cvrebert Maybe open a separate issue for that? |
Use autoprefixer for Customizer builds
|
Opened #15016 regarding the ongoing Firefox Customizer issue |
Fixes #14977.
/cc @cvrebert @XhmikosR