Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up inclusion of IE-specific JS files. #17492

Merged
merged 1 commit into from
Sep 6, 2015
Merged

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Sep 6, 2015

Move them to footer, and remove duplicate ones.

/CC @cvrebert

@XhmikosR XhmikosR added this to the v4.0.0-alpha.2 milestone Sep 6, 2015
@@ -45,8 +45,6 @@
<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.3/jquery.min.js"></script>
<script>window.jQuery || document.write('<script src="../../assets/js/vendor/jquery.min.js"><\/script>')</script>
<script src="../../dist/js/bootstrap.min.js"></script>
<!-- IE10 viewport hack for Surface/desktop Windows 8 bug -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XhmikosR The header copies should be removed, not the footer ones.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I messed it up with the rebases. I'll fix it now.

Move them to footer, and remove duplicate ones.

[ci skip]
@XhmikosR
Copy link
Member Author

XhmikosR commented Sep 6, 2015

Updated.

@cvrebert
Copy link
Collaborator

cvrebert commented Sep 6, 2015

:shipit:

XhmikosR added a commit that referenced this pull request Sep 6, 2015
Clean up inclusion of IE-specific JS files.
@XhmikosR XhmikosR merged commit dde20e9 into v4-dev Sep 6, 2015
@XhmikosR XhmikosR deleted the v4-dev-xmr-docs-js branch September 6, 2015 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants