Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 2 navbar variables to comply with updated naming convention #18472

Merged
merged 1 commit into from
Dec 12, 2015

Conversation

cvrebert
Copy link
Collaborator

@cvrebert cvrebert commented Dec 8, 2015

  • $navbar-padding-horizontal => $navbar-padding-x
  • $navbar-padding-vertical=> $navbar-padding-y

This just leaves 2 breadcrumb vars using the old convention. I'll deal with that in another PR that'll also migrate the breadcrumb component over to being class-based.

$navbar-padding-horizontal => $navbar-padding-x
$navbar-padding-vertical   => $navbar-padding-y

[skip sauce]
[skip validator]
@cvrebert cvrebert added this to the v4.0.0-alpha.3 milestone Dec 8, 2015
@cvrebert
Copy link
Collaborator Author

CC: @mdo for review

cvrebert added a commit that referenced this pull request Dec 12, 2015
Rename 2 navbar variables to comply with updated naming convention
@cvrebert cvrebert merged commit 34fe668 into v4-dev Dec 12, 2015
@cvrebert cvrebert deleted the x-y-vars branch December 12, 2015 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant