Bump Normalize so we can remove Reboot's input[type=search] box-sizing override #19001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So as to pull in necolas/normalize.css#496
| @@ -1,4 +1,4 @@ | |||
| /*! normalize.css v3.0.3 | MIT License | github.com/necolas/normalize.css */ | |||
| /*! normalize.css commit fe56763 | MIT License | github.com/necolas/normalize.css */ | |||
There was a problem hiding this comment.
/*! is needed to preserve the comment for attribution purposes
Revert "fixes #17379: override search input box-sizing to match our global overrides" This reverts commits 468a9d9 & 57998dc. necolas/normalize.css#496 has made this override unnecessary. [skip sauce]
cvrebert
force-pushed
the
bump-normalize
branch
from
b4bcfb5
to
739b51f
Compare
|
Sure. I also don't mind if we fork the project ourselves for future changes like this if we're overriding much more (I can't recall how much there is right meow). |
cvrebert
added a commit
that referenced
this pull request
Jan 24, 2016
Bump Normalize so we can remove Reboot's input[type=search] box-sizing override
|
on a side note, normalize may become more responsive to pushing changes quicker - see necolas/normalize.css#500 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given Normalize's relatively slow development pace, it's not clear whether there'll be a new packaged release any time soon. I propose that we don't wait around for one.
CC: @mdo
(Hat tip to @patrickhlauke for driving the Normalize.css side of this forward)