Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radio and checkbox buttons no longer work (2.0.1) #2023

Closed
rvagg opened this issue Feb 17, 2012 · 5 comments
Closed

radio and checkbox buttons no longer work (2.0.1) #2023

rvagg opened this issue Feb 17, 2012 · 5 comments
Labels
Milestone

Comments

@rvagg
Copy link
Contributor

rvagg commented Feb 17, 2012

Since 139a077, also picked up by @deytao

I guess either go back to event.target or switch the delegate selector to something like '[data-toggle^=button] .btn' causecurrentSelector` is set to the element matched by the delegate selector (even Bean does this now btw!) and at the moment it's the parent of the buttons. See docs/javascript.html, they don't work.

@rvagg
Copy link
Contributor Author

rvagg commented Feb 17, 2012

ah, just found a dupe report, #1987, oh well, it's a serious bug so two reports give it a bit more gravity.

@deytao
Copy link
Contributor

deytao commented Feb 17, 2012

Yes, I totally agree !
It should be done already since a simple revert is enough.

@rvagg
Copy link
Contributor Author

rvagg commented Feb 17, 2012

Scrap that selector change suggestion, it'd break single-toggle buttons. currentTarget seems appropriate though for cases where the buttons contain sub-elements. Just got to sort out that selector I guess: '[data-toggle=button], [data-toggle^=buttons] .btn' would work, a bit verbose tho.

@fat
Copy link
Member

fat commented Feb 18, 2012

A simple revert won't work, but looking into this now :)

@fat
Copy link
Member

fat commented Feb 19, 2012

fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants