Fix mixed-content warnings caused by CarbonAds. #20477
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't better let the browser decide the protocol? |
|
Are we sure that CarbonAds supports HTTPS?
|
|
Thanks I didn't know, btw yes, it supports https as far I know |
|
/cc @mdo |
|
I should also mention that the way Carbon ads are being included causes them to be picked up by Adblock Plus despite them being included in the Acceptable Ads list. |
|
This is due to the As you see, removing it, the AD is displayed correctly: |
|
Alternate fix in 4a63dc6. |
twbs-savage
pushed a commit
to twbs-savage/bootstrap
that referenced
this pull request
Aug 22, 2016
krissihall
pushed a commit
to krissihall/bootstrap
that referenced
this pull request
Sep 7, 2016
…0_aeo-bootstrap * 'v4-dev' of https://github.com/twbs/bootstrap: (860 commits) Update Bower url (HTTP to HTTPS) (twbs#20658) Add Edge entry for twbs#20507 to Wall of Browser Bugs Move Sauce credentials out of .travis.yml new hashes grunt versions grunt Fixes twbs#20608 and twbs#20578: Consistent checkbox and radio markup (twbs#20629) Disable important flag on Sass linter (twbs#20627) Fixes twbs#20619: Add important to the hover/focus as well (twbs#20626) grunt Fix segmented buttons in input group docs (twbs#20489) Renamed contextual classes for tables (twbs#20505) Make .card class inside .card-columns display: block too (twbs#20447) grunt Remove unused $variables in grid mixins (twbs#20597) fixes twbs#20485: use rem units in alert dismiss (twbs#20625) Fix README badge alignment. Update ads code and styles (also fixes twbs#20477 in different way) Fixes twbs#20504: Mention .divider to .dropdown-divider name change ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #20283.