Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove borders on the top and/or bottom when .list-group-flush is the first and/or last child #20903

Merged
merged 1 commit into from
Oct 26, 2016
Merged

Conversation

Starsam80
Copy link
Contributor

Fully fixes #20395

Before:
screenshot2

After:
screenshot3

@mdo
Copy link
Member

mdo commented Oct 15, 2016

Hmm, kinda torn on this. This basically just reimplements the .card...

@Starsam80
Copy link
Contributor Author

Starsam80 commented Oct 15, 2016

Well, all I did was take this code from 955e040#diff-cd8ec88dc7823a5c78f7111e37a78adbL41, and it also fixes things like this:
screenshot4

screenshot5

Edit: Here is a jsfiddle if you want to take a look at it: https://jsfiddle.net/vdny76cc/1/

@Lausselloic
Copy link
Contributor

Hi, the double border top and bottom still be present into alpha.5 http://v4-alpha.getbootstrap.com/components/card/#content-types

Maybe just add a border-top: 0 to the first list-group-item and border-bottom: 0 to the last one?
in _card.scss line 51-63 actual code
.card {

.list-group:first-child {
.list-group-item:first-child {
@include border-top-radius($card-border-radius);
}
}

.list-group:last-child {
.list-group-item:last-child {
@include border-bottom-radius($card-border-radius);
}
}
}

Proposition to fix it :
.card {

.list-group:first-child {
.list-group-item:first-child {
@include border-top-radius($card-border-radius);
border-top: 0;
}
}

.list-group:last-child {
.list-group-item:last-child {
@include border-bottom-radius($card-border-radius);
border-bottom: 0;
}
}
}

@mdo
Copy link
Member

mdo commented Oct 26, 2016

Well, all I did was take this code from 955e040#diff-cd8ec88dc7823a5c78f7111e37a78adbL41, and it also fixes things like this:

Ahhhh yeah @Starsam80, good point. 😆 Merging!

@mdo mdo added this to the v4.0.0-alpha.6 milestone Oct 26, 2016
@mdo mdo merged commit 182a642 into twbs:v4-dev Oct 26, 2016
@mdo mdo mentioned this pull request Oct 26, 2016
@Starsam80 Starsam80 deleted the fix-20395 branch October 26, 2016 03:53
Lausselloic added a commit to Orange-OpenSource/Orange-Boosted-Bootstrap that referenced this pull request Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Alpha 6
Fixed/Merged
Development

Successfully merging this pull request may close these issues.

None yet

3 participants