Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacing sizes are a bit counter-intuitive #21702

Closed
entozoon opened this issue Jan 13, 2017 · 2 comments
Closed

Spacing sizes are a bit counter-intuitive #21702

entozoon opened this issue Jan 13, 2017 · 2 comments
Labels

Comments

@entozoon
Copy link
Contributor

entozoon commented Jan 13, 2017

Referring to the spacing sizes explained in:
https://v4-alpha.getbootstrap.com/utilities/spacing/

I was surprised to see that these aren't linear increments 0, 1, 2, 3, etc as might be expected by the classnames (i.e. p-3 yields 1 spacers worth, rather than 3)

but aside from that, with the pattern they currently have, it looks like they're supposed to double up each increment but they don't - the pattern being 0, 0.25, 0.5, 1, 1.5, 3 which is inconsistent.

Perhaps there's a logical reason?
If not, I've popped in a pull request for a consistent doubling up pattern 0, 0.25, 0.5, 1, 2, 4 although (in my opinion) linear increments might be better, for which I'd happily do a PR if desirable.

#21703

@Starsam80
Copy link
Contributor

Duplicate of #21342.

@mdo
Copy link
Member

mdo commented Jan 16, 2017

Closing as dupe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants