Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with container in nav(bar) width on small screens: Brand and toggler overlap #21848

Closed
manitu-opensource opened this issue Jan 26, 2017 · 2 comments
Labels

Comments

@manitu-opensource
Copy link

manitu-opensource commented Jan 26, 2017

Having this (on BS 4 alpha 6)

<nav class="navbar navbar-static-top navbar-toggleable-md navbar-light bg-faded">

	<div class="container">
	
	    <button class="navbar-toggler navbar-toggler-right" type="button" data-toggle="collapse" data-target="#navbar-toggler-div" aria-controls="navbar-toggler-div" aria-expanded="false" aria-label="Navigation">
	        <i class="fa fa-bars"></i>
	    </button>
	
	    <a class="navbar-brand" href="/">
	        Band name here
	    </a>
	
	    <div class="collapse navbar-collapse" id="navbar-toggler-div">
	
	        <ul class="navbar-nav">
	
	            <li class="nav-item">
	                <a class="nav-link" href="#">Foo</a>
	            </li>
	
	            <li class="nav-item">
	                <a class="nav-link" href="#">Bar</a>
	            </li>
	
	        </ul>
	
	    </div>
	
	</div>

</nav>

(see https://jsfiddle.net/p47Lqb9f/ )

Problem: On small screens the brand name and the toggler overlap.

It seems to me that the container inside the nav is not wide enough. It's size is reduced due to media queries.

Possible solution: A possible fix is

@media (max-width: 576px) {
	nav .container {
	    width: 100%;
	}
}
@josmaissan
Copy link
Contributor

josmaissan commented Jan 26, 2017

I think this is the same as #21590 and solved in #21722

@bardiharborow
Copy link
Member

Closing as duplicate of #21590. Holler if there's something I've missed. <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants