[Docs v3] Typo in Modal Example #22265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
idk why the travis build fail? I doesn't change anything on the gemfile? |
|
Bootstrap 3 is essentially in maintenance mode as we focus on working towards a stable v4. As such, we're only accepting changes to v3's code on a case-by-case basis, usually only for critical bug fixes or docs improvements. This is a saved reply. |
|
@mdo that is a doc improvement, because if you copy & paste the example actually it doesn't work. |
|
Yup, but only on a case by case basis. I'm basically not making any v3 changes until v4 ships. Sorry, just trying to stay focused and ship an update. <3 |
mdo
added a commit
that referenced
this pull request
Jul 10, 2017
XhmikosR
pushed a commit
that referenced
this pull request
Apr 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
i found an "typo" in the Docs for v3.3.7.
In the example is the class: "bs-example-modal-lg" (and "bs-example-modal-sm") used. If you copy & paste this example, it doesn't work. The right classes are "modal-lg" and "modal-sm".