Add a badge to track our dependencies #23125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only commen is that I'd move the dependencies badge before the devDependencies one. Other than that, I'm definitely in favor of requiring jQuery 3.x. |
|
Thank you @XhmikosR , I made those changes 👍 |
mdo
approved these changes
Jul 20, 2017
|
I quickly merged this, but we might need to revisit for |
Closed
|
It seems ok because you merged v4-dev in this branch |
|
Oh yeah sorry I just woke up... But yeah now we need a |
|
Yeah what @Johann-S said :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a badge to track easely our dependencies, currently this badge looks like that (inSecure) :
Because we choose to require at least jQuery
1.9.1but all the release of jQuery under jQuery3are vulnerable to this XSS issue : https://nodesecurity.io/advisories/jquery_xssSo I recommand to change our required jQuery version to :
>=3.0.0Side Note : jQuery
3compatibility https://jquery.com/browser-support//CC @mdo @XhmikosR @bardiharborow