Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix headers conflicting with pre #23257

Closed

Conversation

MartijnCuppens
Copy link
Member

@MartijnCuppens MartijnCuppens commented Aug 8, 2017

Fixes #23252. This sets pointer-events: none; on the heading-elements and pointer-events: auto; on the direct child. All content in the heading-elements is wrapped in spans by jQuery.

@mdo
Copy link
Member

mdo commented Aug 8, 2017

Does #23244 not handle this well enough?

@XhmikosR
Copy link
Member

XhmikosR commented Aug 8, 2017

@mdo you probably meant #23256, which does not fix the issue as I mentioned there.

As for this, @MartijnCuppens this has nothing to do with Microsoft. Unless you mean something else with "ms".

Also, please skip the generated files.

Other than that this is the proper fix so 👍

Copy link
Member

@XhmikosR XhmikosR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After removing the generated files and rebasing skipping @mdo's patch completely, we can merge this

@XhmikosR XhmikosR changed the title Sticky header ms Fix headers conflicting with pre Aug 8, 2017
mdo added a commit that referenced this pull request Aug 9, 2017
@mdo mdo mentioned this pull request Aug 9, 2017
@mdo
Copy link
Member

mdo commented Aug 9, 2017

Cleaned up and superseded with #23259.

@mdo mdo closed this Aug 9, 2017
mdo added a commit that referenced this pull request Aug 9, 2017
@MartijnCuppens MartijnCuppens deleted the sticky-header-ms branch December 31, 2017 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants