Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

button-variant mixin - calculating active color #23514

Closed
jan-vodila opened this issue Aug 17, 2017 · 1 comment
Closed

button-variant mixin - calculating active color #23514

jan-vodila opened this issue Aug 17, 2017 · 1 comment

Comments

@jan-vodila
Copy link

jan-vodila commented Aug 17, 2017

Hi, guys

I thinks that button-variant mixin should calculate color property for hover state from its $active-background variable not the $background var. The problem is when I want a black button to change its background-color to white it leaves the color property also white not black as I would expected.

See here:

@include color-yiq($background);

What do you think?

@mdo
Copy link
Member

mdo commented Sep 4, 2017

Fixed by #23657.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4 Beta 2
Shipped
Development

No branches or pull requests

3 participants