Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update js/tests/README.md #24281

Merged
merged 1 commit into from
Oct 6, 2017
Merged

Update js/tests/README.md #24281

merged 1 commit into from
Oct 6, 2017

Conversation

vsn4ik
Copy link
Contributor

@vsn4ik vsn4ik commented Oct 6, 2017

No description provided.

* Each test should begin with [`assert.expect`](https://api.qunitjs.com/expect/) to ensure that the expected assertions are run.
* Each test should follow the project's [JavaScript Code Guidelines](https://github.com/twbs/bootstrap/blob/master/CONTRIBUTING.md#js)
* Each test should begin with [`assert.expect`](https://api.qunitjs.com/assert/expect/) to ensure that the expected assertions are run.
* Each test should follow the project's [JavaScript Code Guidelines](https://github.com/twbs/bootstrap/blob/v4-dev/.github/CONTRIBUTING.md#js)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't change this because eventually v4-dev will be merged to master.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XhmikosR Fixed

@XhmikosR XhmikosR requested a review from Johann-S October 6, 2017 21:00
@XhmikosR XhmikosR added the v4 label Oct 6, 2017
@vsn4ik
Copy link
Contributor Author

vsn4ik commented Oct 6, 2017

Labels: meta?

@XhmikosR XhmikosR merged commit 1aea9d7 into twbs:v4-dev Oct 6, 2017
@vsn4ik vsn4ik deleted the v4-dev-update-tests-readme-file branch October 6, 2017 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants