Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility nav tabs : disabled tabs need to have tabindex set to -1 #24436

Closed
Lausselloic opened this issue Oct 19, 2017 · 5 comments
Closed

Comments

@Lausselloic
Copy link
Contributor

To prevent keyboard focus, when a tab is disabled, we need to set the tabindex to -1

http://getbootstrap.com/docs/4.0/components/navs/#tabs

Can be done in static mode for the doc, and also could be managed by the plugin.

Maybe also need to use the aria-disabled attribute to inform screen reader.

@alecpl
Copy link
Contributor

alecpl commented Oct 19, 2017

Please, fix the title. It's not z-index, but tabindex.

@patrickhlauke patrickhlauke changed the title Accessibility nav tabs : disabled tabs need to have z-index set to -1 Accessibility nav tabs : disabled tabs need to have tabindex set to -1 Oct 19, 2017
@Lausselloic
Copy link
Contributor Author

oh yes i'm confused

@Varunram
Copy link
Contributor

@patrickhlauke Still on this or may I put in a PR? :)

@XhmikosR
Copy link
Member

@Varunram: I don't even know if @patrickhlauke saw this; I had assigned it to him back then.

So, just go ahead.

@patrickhlauke
Copy link
Member

Seems to have been sorted now (though one instance of disabled links that are still focusable/not marked with aria-disabled remained, which will be fixed by #27788).

Closing (and apologies for not actioning this at the time...life got in the way)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants