Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input group support for custom selects and custom files #24455

Merged
merged 4 commits into from
Oct 23, 2017

Conversation

mdo
Copy link
Member

@mdo mdo commented Oct 20, 2017

Closes #24437, closes #22457

display: -ms-flexbox;
display: flex;
-ms-flex-align: center;
align-items: center;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected indentation of 2 spaces indentation

.input-group .custom-file {
display: -ms-flexbox;
display: flex;
-ms-flex-align: center;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected vendor-prefix "-ms-flex-align" property-no-vendor-prefix

border-radius: 0;
}

.input-group .custom-file {
display: -ms-flexbox;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected vendor-prefix "-ms-flexbox" value-no-vendor-prefix

@XhmikosR
Copy link
Member

There's a duplicate id here @mdo; I'll leave it to you to fix later.

@mdo mdo added this to Needs review in v4 Beta 3 Oct 21, 2017
@mdo mdo moved this from Needs review to Shipped in v4 Beta 3 Oct 23, 2017
@mdo mdo merged commit 137b680 into v4-dev Oct 23, 2017
@mdo mdo mentioned this pull request Oct 23, 2017
@XhmikosR XhmikosR deleted the input-group-custom-forms branch October 23, 2017 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v4 Beta 3
  
Shipped
Development

Successfully merging this pull request may close these issues.

None yet

3 participants