Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples updates #24898

Merged
merged 72 commits into from
Jan 15, 2018
Merged

Examples updates #24898

merged 72 commits into from
Jan 15, 2018

Conversation

mdo
Copy link
Member

@mdo mdo commented Nov 28, 2017

Fixes bugs, updates to newer techniques, and adds some new examples. In addition, I've replaced the old examples.md file with an examples.html that loops over a new data file, examples.yml, to generate our list of examples.

  • Added four new examples—Pricing, Checkout, Product, and Floating Labels. Closes added pricing tables to the examples #18296.

  • Overhauled Dashboard with a brand new navbar and layout, large Chartjs example instead of placeholder circles, icons from Feather, and more.

  • Redesigned Offcanvas completely to be a mobile-focused example that integrates a drawer menu into the Bootstrap navbar.

  • Redesigned Blog to give it the appearance of popular blogging platforms and magazines, featuring horizontal cards, Google Web Fonts, and more.

  • Updated Sign-in to vertically center the form via flexbox and add more copy, images, and footer.

  • Refreshed Album to remove the bulk of the .card overrides, add more components to the albums, and improve the visual styles.

  • Updated Cover to replace the table hack for vertical centering with flexbox, simplifying the HTML and CSS. Also fixed a bug where the nav would be left aligned on mobile devices.

Still have some more to do here, so leaving as WIP for v4 stable.

  • Responsive Product
  • Spacing on responsive Checkout
  • Medium responsive on Pricing
  • Responsive Blog (cards, scrolling nav)
  • Retake screenshots
  • Compress screenshots
  • Squash useless commits

Closes #22847, takes a first pass implementation for #21312.

@mdo mdo added this to Inbox in v4.0 stable via automation Nov 28, 2017
@XhmikosR XhmikosR force-pushed the examples-cleanup branch 2 times, most recently from 4c9dfa6 to b591959 Compare November 28, 2017 06:22
@XhmikosR
Copy link
Member

@mdo: when you are ready, please squash any patches that can be squashed.

@mdo mdo moved this from Inbox to Ready to merge in v4.0 stable Jan 4, 2018
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jumbotron narrow? Oh dear, my most beloved example... 😟

@mdo mdo merged commit e946348 into v4-dev Jan 15, 2018
v4.0 stable automation moved this from Ready to merge to Shipped Jan 15, 2018
@mdo mdo deleted the examples-cleanup branch January 15, 2018 00:06
@mdo mdo mentioned this pull request Jan 15, 2018
@fulldecent
Copy link
Contributor

Hello from the Chart.js team. Thanks for adding the example!

@mdo
Copy link
Member Author

mdo commented Jan 19, 2018

@fulldecent Woohoo! Holler if there's anything else we can do to improve the page! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4.0 stable
  
Shipped
Development

Successfully merging this pull request may close these issues.

None yet

3 participants