New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accordion Example: ID and class duplicated in v. 4.1 #26389

Closed

AlessandroVecchi opened this issue Apr 26, 2018 · 6 comments

Labels

AlessandroVecchi commented Apr 26, 2018

4.0
https://getbootstrap.com/docs/4.0/components/collapse/#accordion-example
<div id="accordion">

4.1
https://getbootstrap.com/docs/4.1/components/collapse/#accordion-example
<div class="accordion" id="accordion">

why?

The text was updated successfully, but these errors were encountered:

Member

Johann-S commented Apr 26, 2018

a bit weird yes, because we don't have .accordion in our CSS 🤔

Johann-S added docs v4 labels

Member

patrickhlauke commented Apr 26, 2018

Author

AlessandroVecchi commented Apr 26, 2018

I think it would be better:
<div class="accordion" id="accordionExample">

Member

Johann-S commented Apr 26, 2018

Closed thanks to @patrickhlauke 👍

Johann-S closed this as completed

Member

patrickhlauke commented Apr 26, 2018

yeah the id could be tweaked for clarity

patrickhlauke mentioned this issue

Change accordion example id #26391

Merged

Member

patrickhlauke commented Apr 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment