-
-
Notifications
You must be signed in to change notification settings - Fork 78.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.show class leaked on navlink #28118
Comments
Yep I think too, maybe @MartijnCuppens wants to fix that ? |
@MartijnCuppens: any progress with this? |
I forgot about this, I'll have a look at it now and check if we can write a test to prevent this from happening. |
Reverting https://github.com/twbs/bootstrap/pull/27533/files#diff-02a6d2619ddbbd65ac148de3377674eeL174 would indeed "fix" this issue, but there's another issue here: we shouldn't add the Let's analyse these lines: Lines 111 to 133 in f134d4b
The @Johann-S could you help here? |
Bootstrap 4.2.1: on every dynamic tabbed interface, whenever I click on a
.tablink
the classes.active .show
are properly added to the new item but the.show
class is not removed from the previously active item. If this is an issue, it seems to be a regression because with bootstrap 4.1.3 all is working as expected.Here is a MWE using pills; just inspect Home or Profile while switching between the two panes: https://jsfiddle.net/4oy92hmx/
The text was updated successfully, but these errors were encountered: