Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap 4.2.1 toast delay does not 'restart' if the toast is shown again before the timeout ends #28164

Closed
karimcambridge opened this issue Feb 2, 2019 · 7 comments · Fixed by #31155
Labels

Comments

@karimcambridge
Copy link

karimcambridge commented Feb 2, 2019

The title explains it well.

    clearTimeout(this._timeout)
}

The code above should be added in show() for the toast class at

show() {

  • Windows 10.0.17763 Build 17763
  • Version 71.0.3578.98 (Official Build) (64-bit)

Don't think there is need for a test case.

@Johann-S
Copy link
Member

Johann-S commented Feb 6, 2019

Hi @karimcambridge,

I tried to reproduce your issue but I'm not able to 😟
See my CodePen: https://codepen.io/Johann-S/pen/QYqrPw

@karimcambridge
Copy link
Author

https://codepen.io/karimcambridge/pen/RvLdGr

Try now, with a larger data-delay (5000).

@Johann-S
Copy link
Member

Johann-S commented Feb 6, 2019

Hmm ok now I understand 👍

For me in this particular use case, I would call manually show and hide method to avoid that behavior, but you're right we should fix that 👍

@karimcambridge
Copy link
Author

Thank you.

@jeffehobbs
Copy link

FYI for anyone still grappling with this, I worked around it by "disposing" of the toast before showing it again.

@karimcambridge
Copy link
Author

Same, but needs to be fixed.

@davidluhn
Copy link

Has this been fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants