v5: Drop all print styles and classes #28339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
changed the title
|
I wouldn't drop |
13 tasks
|
Should be ready for review now, @twbs/css-review. |
mdo
changed the title
MartijnCuppens
approved these changes
May 8, 2019
XhmikosR
reviewed
May 8, 2019
|
So, just a last comment. Are we 100% sure about this? I mean, if you just do a print preview of our docs and compare you will see how bad it is now. |
|
It's actually better here (Chrome, mac) and on Firefox it's equally bad. Our print styles fix some things while introducing other issues. We might have a look at reintroducing print style sheets or optimizing our docs if we know for sure we don't break anything else. |
crhistianramirez
pushed a commit
to crhistianramirez/headstart
that referenced
this pull request
Dec 28, 2022
Removed print styles and $enable-print-styles variable. Print display classes are still around. See twbs/bootstrap#28339
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the print styles, print utilities, and more. Far too many bugs around this stuff for us to keep maintaining as so much of it depends on the exact page design and layout.