Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use hugo.Environment instead of getenv #29240

Merged
merged 2 commits into from
Feb 22, 2020
Merged

Use hugo.Environment instead of getenv #29240

merged 2 commits into from
Feb 22, 2020

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Aug 10, 2019 •
edited

This is set automatically to "development" when the local server is running, and to "production" when Hugo builds the site.

WIP because I like the flexibility. I might change the patch to set the environment with Hugo's --environment CLI flag instead.

@XhmikosR XhmikosR added this to Inbox in v5 via automation Aug 10, 2019
@mdo mdo added this to Inbox in v5.0.0-alpha2 via automation Feb 17, 2020
@mdo mdo removed this from Inbox in v5 Feb 17, 2020
@XhmikosR
Use hugo.Environment instead of getenv
ee01fcd 
This is set automatically to "development" when the local server is running, and to "production" when Hugo builds the site.
@XhmikosR XhmikosR removed the on-hold label Feb 18, 2020
@XhmikosR XhmikosR added this to Inbox in v5 via automation Feb 20, 2020
@XhmikosR XhmikosR removed this from Inbox in v5.0.0-alpha2 Feb 20, 2020
mdo
mdo approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested this locally, but diff looks right to me!

v5 automation moved this from Inbox to Approved Feb 21, 2020
@XhmikosR XhmikosR merged commit b8ffcdf into master Feb 22, 2020
v5 automation moved this from Approved to Shipped Feb 22, 2020
@XhmikosR XhmikosR deleted the master-xmr-hugo-env branch February 22, 2020 06:54
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
@XhmikosR @olsza
Use hugo.Environment instead of getenv (twbs#29240)
d9b6e29 
This is set automatically to "development" when the local server is running, and to "production" when Hugo builds the site.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

@MartijnCuppens MartijnCuppens Awaiting requested review from MartijnCuppens

Assignees
No one assigned
Labels
docs v5
Projects
No open projects
v5
  
Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@XhmikosR @mdo