v5: Simplify navbars by requiring containers #29339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this idea, was thinking about doing this myself one day Edit: lol, I did even mention that here: #25274 (comment) |
XhmikosR
force-pushed
the
navbar-require-containers
branch
from
f9fb374
to
ca52f79
Compare
|
Rebased and addressed @MartijnCuppens's comment. |
|
Shouldn't we mention this in migration? |
We should |
XhmikosR
force-pushed
the
navbar-require-containers
branch
from
c4afb2b
to
042a613
Compare
MartijnCuppens
force-pushed
the
navbar-require-containers
branch
from
18abd88
to
43aefdc
Compare
MartijnCuppens
approved these changes
Oct 27, 2019
|
Love it! Great work guys |
This was referenced Dec 24, 2019
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
* v5: Simplify navbars by requiring containers * Update migration docs for navbar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25274 by @zalog.
Unsure if we want to go with this, but I believe @MartijnCuppens suggested it somewhere. It does simplify behavior of the navbar a bit, and it ensures horizontal alignment from @zalog's original reported issue.
Thoughts @twbs/css-review?
TODO: