Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add font style normal #29744

Merged
merged 3 commits into from
Dec 6, 2019
Merged

Add font style normal #29744

merged 3 commits into from
Dec 6, 2019

Conversation

mattvgn
Copy link
Contributor

@mattvgn mattvgn commented Nov 26, 2019 •
edited by XhmikosR

Fixes #29590

I was not confident about changing font-italic to font-style-italic because it would break some people style.

@mattvgn mattvgn requested a review from a team as a code owner November 26, 2019 22:05
MartijnCuppens
MartijnCuppens approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mattvgn!

@MartijnCuppens MartijnCuppens added this to Inbox in v5 via automation Nov 27, 2019
@XhmikosR XhmikosR merged commit 1a5b7f4 into twbs:master Dec 6, 2019
v5 automation moved this from Inbox to Shipped Dec 6, 2019
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
@mattvgn @olsza
Add font style normal (twbs#29744)
c1f1ad5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartijnCuppens MartijnCuppens MartijnCuppens approved these changes

Assignees
No one assigned
Labels
css feature no-backport-to-v4 v5
Projects
No open projects
v5
  
Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add font-style-normal
3 participants
@mattvgn @MartijnCuppens @XhmikosR