Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal Documentation for Vertically Centered isn't Correct #30055

Closed
DaleyKD opened this issue Jan 20, 2020 · 1 comment · Fixed by #30325
Closed

Modal Documentation for Vertically Centered isn't Correct #30055

DaleyKD opened this issue Jan 20, 2020 · 1 comment · Fixed by #30325
Labels
docs has-pr v4 v5

Comments

@DaleyKD
Copy link

DaleyKD commented Jan 20, 2020

The docs for the vertically centered don't appear to fully match what should be shown. The "Launch Demo Modal" text should be "Vertically centered modal," but what really matters is that there's no class mentioned for modal-dialog-scrollable in the Vertically Centered section.
image

Very minor issue.
@ysds ysds added the docs label Jan 23, 2020
@ysds ysds mentioned this issue Mar 2, 2020
Merged
@mdo mdo added this to Inbox in v5 via automation Mar 20, 2020
@mdo mdo added this to To do in v4.5.0 via automation Mar 20, 2020
v5 automation moved this from Inbox to Shipped Mar 23, 2020
@XhmikosR XhmikosR removed this from To do in v4.5.0 Mar 26, 2020
@XhmikosR XhmikosR removed this from Shipped in v5 Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs has-pr v4 v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update modal docs twbs/bootstrap
4 participants
@mdo @ysds @DaleyKD and others