Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example dashboard: fix menu disappearing on small viewport #30272

Merged
merged 2 commits into from
Mar 4, 2020
Merged

Example dashboard: fix menu disappearing on small viewport #30272

merged 2 commits into from
Mar 4, 2020

Conversation

Minobi
Copy link

@Minobi Minobi commented Feb 23, 2020

Closes #30186 add toggle button to navbar to toggle menu visibility on small viewports.

Preview: https://deploy-preview-30272--twbs-bootstrap.netlify.com/docs/4.3/examples/dashboard/

@Minobi Minobi requested a review from a team as a code owner February 23, 2020 12:51
site/content/docs/4.3/examples/dashboard/dashboard.css Outdated Show resolved Hide resolved
site/content/docs/4.3/examples/dashboard/index.html Outdated Show resolved Hide resolved
@XhmikosR
Copy link
Member

@mdo you call, and also if we should backport this or not.

@XhmikosR XhmikosR self-requested a review March 2, 2020 07:51
@XhmikosR XhmikosR added this to Inbox in v5 via automation Mar 2, 2020
@mdo mdo added this to Inbox in v4.5.0 via automation Mar 3, 2020
v5 automation moved this from Inbox to Approved Mar 3, 2020
@XhmikosR XhmikosR merged commit 0cfd8df into twbs:master Mar 4, 2020
v5 automation moved this from Approved to Shipped Mar 4, 2020
@XhmikosR XhmikosR moved this from Inbox to Cherry-picked in v4.5.0 Mar 4, 2020
@XhmikosR XhmikosR moved this from Cherry-picked to Shipped in v4.5.0 Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4.5.0
  
Shipped
v5
  
Shipped
Development

Successfully merging this pull request may close these issues.

Add note to dashboard example to indicate it is NOT mobile friendly
4 participants