Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenting CSS vars usage in upcoming Customize docs section #30575

Merged
merged 1 commit into from
May 2, 2020

Conversation

mdo
Copy link
Member

@mdo mdo commented Apr 13, 2020

WIP, but trying to capture some of the work @MartijnCuppens and @ffoodd are doing across multiple PRs. Fellas, please weigh in here on anything else we should be striving to mention. Some thoughts from me thus far mean we could include guidelines for how we decide what gets CSS vars, how to customize and utilize them, how we generate them with Sass, etc.


X-ref: #26596

@mdo mdo force-pushed the docs-customize-section branch 5 times, most recently from 8bf48a2 to 3e919a1 Compare April 16, 2020 00:13
@mdo mdo force-pushed the docs-customize-section branch 2 times, most recently from 38eb410 to b090c7d Compare April 24, 2020 20:14
@mdo mdo changed the base branch from docs-customize-section to master April 30, 2020 04:01
@mdo mdo marked this pull request as ready for review April 30, 2020 04:13
@mdo mdo added this to Inbox in v5 via automation Apr 30, 2020
@mdo mdo requested a review from a team April 30, 2020 04:14
@mdo mdo mentioned this pull request Apr 30, 2020
4 tasks
v5 automation moved this from Inbox to Approved Apr 30, 2020
@ffoodd
Copy link
Member

ffoodd commented Apr 30, 2020

LGTM. @MartijnCuppens?

@MartijnCuppens
Copy link
Member

support dynamic restyling and extending of Bootstrap components without recompiling Sass

I'm not sure about this. You can't just convert all Sass variables into custom properties.

For example, the buttons. They have :hover, :focus & :active states. These states use colors that are generated by Sass and if you change for example var(--primary), those colors won't change. Likewise, contrast colors won't automatically adjust.

As long as we don't have native CSS color functions, this idea won't work.

@mdo
Copy link
Member Author

mdo commented Apr 30, 2020

I'll fine-tune that copy and make sure I'm not implying something we cannot technically do.

@mdo mdo force-pushed the docs-customize-css-vars branch from 1ca3f9f to 7c6d5f2 Compare May 1, 2020 18:41
@mdo mdo force-pushed the docs-customize-css-vars branch from 7c6d5f2 to e0185e9 Compare May 1, 2020 18:52
@mdo
Copy link
Member Author

mdo commented May 1, 2020

Pulled back on the customization/extension bits... I think this is okay? Doesn't overpromise and clarifies some other pieces. Also removed buttons from the last line there.

Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful.

@mdo mdo merged commit 1f531a6 into master May 2, 2020
v5 automation moved this from Approved to Shipped May 2, 2020
@mdo mdo deleted the docs-customize-css-vars branch May 2, 2020 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5
  
Shipped
Development

Successfully merging this pull request may close these issues.

None yet

3 participants