-
-
Notifications
You must be signed in to change notification settings - Fork 78.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documenting CSS vars usage in upcoming Customize docs section #30575
Conversation
8bf48a2
to
3e919a1
Compare
38eb410
to
b090c7d
Compare
e245cab
to
1ca3f9f
Compare
LGTM. @MartijnCuppens? |
I'm not sure about this. You can't just convert all Sass variables into custom properties. For example, the buttons. They have As long as we don't have native CSS color functions, this idea won't work. |
I'll fine-tune that copy and make sure I'm not implying something we cannot technically do. |
1ca3f9f
to
7c6d5f2
Compare
7c6d5f2
to
e0185e9
Compare
Pulled back on the customization/extension bits... I think this is okay? Doesn't overpromise and clarifies some other pieces. Also removed buttons from the last line there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful.
WIP, but trying to capture some of the work @MartijnCuppens and @ffoodd are doing across multiple PRs. Fellas, please weigh in here on anything else we should be striving to mention. Some thoughts from me thus far mean we could include guidelines for how we decide what gets CSS vars, how to customize and utilize them, how we generate them with Sass, etc.
X-ref: #26596