Disable negative margins by default #30585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdo
reviewed
Apr 14, 2020
mdo
approved these changes
Apr 14, 2020
|
@mdo @MartijnCuppens maybe we should reconsider this patch? I mean, I know it saves us a lot from the dist files, but it's something that we have in v4 and it seems like a good thing to have by default. Assuming we'll proceed with using CSS vars more, the dist size will drop anyway. |
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
* Disable negative margins by default * Use shorter enable variable Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Negative margins were introduced to create/hack responsive gutter widths in BS 4.2. But since we now have the responsive gutter, those classes are now less applicable. Also, since we now have an
xxlbreakpoint, our file size has increased quite a lot, since there are lots of negative margins.Negative margins can be useful, but I don't think we should enable them by default, therefore using a
$enable-variable feels like a good idea.