Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bs- prefixes to custom properties #30591

Merged
merged 2 commits into from
Apr 15, 2020

Conversation

MartijnCuppens
Copy link
Member

Closes #30558.

Also shortened the font-family custom properties a bit, since we also ditch the family in the class names. Also did this for the gutter variables, just to save some bytes.

@MartijnCuppens MartijnCuppens requested a review from a team as a code owner April 15, 2020 12:28
@MartijnCuppens MartijnCuppens added this to Inbox in v5 via automation Apr 15, 2020
v5 automation moved this from Inbox to Approved Apr 15, 2020
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done :)

@MartijnCuppens MartijnCuppens merged commit 8cdb057 into master Apr 15, 2020
v5 automation moved this from Approved to Shipped Apr 15, 2020
@MartijnCuppens MartijnCuppens deleted the master-mc-prefix-custom-properties branch April 15, 2020 16:52
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5
  
Shipped
Development

Successfully merging this pull request may close these issues.

Prefix custom properties with bs-
2 participants